hero123457/xrdp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix parameter order inconsistency.

Browse Source 
The parameter odering of some of the append routines is
inconsistent both with the function comment headers, and
with libipm_recv.c
This commit is contained in:
matt335672 2023-01-09 14:24:14 +00:00
parent ad7cb5c726
commit dfc636f587
1 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
libipm/libipm_send.c
View File

@ -94,7 +94,7 @@ bad_value_msg = "Type '%c' has unsupported value '%d'";
* The boolean value must be a 0 or a 1. * The boolean value must be a 0 or a 1.
*/ */
static enum libipm_status static enum libipm_status
append_bool_type(char c, va_list *argptr, struct trans *trans) append_bool_type(char c, struct trans *trans, va_list *argptr)
{ {
enum libipm_status rv = E_LI_SUCCESS; enum libipm_status rv = E_LI_SUCCESS;
struct stream *s = trans->out_s; struct stream *s = trans->out_s;
@ -129,7 +129,7 @@ append_bool_type(char c, va_list *argptr, struct trans *trans)
* @return != 0 for error * @return != 0 for error
*/ */
static enum libipm_status static enum libipm_status
append_int8_type(char c, va_list *argptr, struct trans *trans) append_int8_type(char c, struct trans *trans, va_list *argptr)
{ {
enum libipm_status rv = E_LI_SUCCESS; enum libipm_status rv = E_LI_SUCCESS;
struct stream *s = trans->out_s; struct stream *s = trans->out_s;
@ -164,7 +164,7 @@ append_int8_type(char c, va_list *argptr, struct trans *trans)
* @return != 0 for error * @return != 0 for error
*/ */
static enum libipm_status static enum libipm_status
append_int16_type(char c, va_list *argptr, struct trans *trans) append_int16_type(char c, struct trans *trans, va_list *argptr)
{ {
enum libipm_status rv = E_LI_SUCCESS; enum libipm_status rv = E_LI_SUCCESS;
struct stream *s = trans->out_s; struct stream *s = trans->out_s;
@ -200,7 +200,7 @@ append_int16_type(char c, va_list *argptr, struct trans *trans)
* @return != 0 for error * @return != 0 for error
*/ */
static enum libipm_status static enum libipm_status
append_int32_type(char c, va_list *argptr, struct trans *trans) append_int32_type(char c, struct trans *trans, va_list *argptr)
{ {
enum libipm_status rv = E_LI_SUCCESS; enum libipm_status rv = E_LI_SUCCESS;
struct stream *s = trans->out_s; struct stream *s = trans->out_s;
@ -246,7 +246,7 @@ append_int32_type(char c, va_list *argptr, struct trans *trans)
* @return != 0 for error * @return != 0 for error
*/ */
static enum libipm_status static enum libipm_status
append_int64_type(char c, va_list *argptr, struct trans *trans) append_int64_type(char c, struct trans *trans, va_list *argptr)
{ {
enum libipm_status rv = E_LI_SUCCESS; enum libipm_status rv = E_LI_SUCCESS;
struct stream *s = trans->out_s; struct stream *s = trans->out_s;
@ -275,7 +275,7 @@ append_int64_type(char c, va_list *argptr, struct trans *trans)
* NULL pointers are not allowed for the string. * NULL pointers are not allowed for the string.
*/ */
static enum libipm_status static enum libipm_status
append_char_ptr_type(char c, va_list *argptr, struct trans *trans) append_char_ptr_type(char c, struct trans *trans, va_list *argptr)
{ {
enum libipm_status rv = E_LI_SUCCESS; enum libipm_status rv = E_LI_SUCCESS;
struct stream *s = trans->out_s; struct stream *s = trans->out_s;
@ -315,7 +315,7 @@ append_char_ptr_type(char c, va_list *argptr, struct trans *trans)
* @return != 0 for error * @return != 0 for error
*/ */
static enum libipm_status static enum libipm_status
append_fsb_type(char c, va_list *argptr, struct trans *trans) append_fsb_type(char c, struct trans *trans, va_list *argptr)
{ {
enum libipm_status rv = E_LI_SUCCESS; enum libipm_status rv = E_LI_SUCCESS;
struct stream *s = trans->out_s; struct stream *s = trans->out_s;
@ -379,34 +379,34 @@ libipm_msg_out_appendv(struct trans *trans, const char *format, va_list *argptr)
switch (c) switch (c)
{ {
case 'y': case 'y':
rv = append_int8_type(c, argptr, trans); rv = append_int8_type(c, trans, argptr);
break; break;
case 'b': case 'b':
rv = append_bool_type(c, argptr, trans); rv = append_bool_type(c, trans, argptr);
break; break;
case 'n': case 'n':
case 'q': case 'q':
rv = append_int16_type(c, argptr, trans); rv = append_int16_type(c, trans, argptr);
break; break;
case 'i': case 'i':
case 'u': case 'u':
rv = append_int32_type(c, argptr, trans); rv = append_int32_type(c, trans, argptr);
break; break;
case 'x': case 'x':
case 't': case 't':
rv = append_int64_type(c, argptr, trans); rv = append_int64_type(c, trans, argptr);
break; break;
case 's': case 's':
rv = append_char_ptr_type(c, argptr, trans); rv = append_char_ptr_type(c, trans, argptr);
break; break;
case 'B': case 'B':
rv = append_fsb_type(c, argptr, trans); rv = append_fsb_type(c, trans, argptr);
break; break;
default: default: