hero123457/xrdp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove size limit for PAM environment variables

Browse Source 
The current logic in auth_set_env() for PAM environments only allows
environment variables to be around 256 characters in length.
This commit is contained in:
matt335672 2023-05-31 16:30:58 +01:00
parent 6c9f7f8434
commit 3d2b3b89f4
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
sesman/verify_user_pam.c
View File

@ -419,9 +419,6 @@ auth_set_env(long in_val)
struct t_auth_info *auth_info;
char **pam_envlist;
char **pam_env;
char item[256];
char value[256];
int eq_pos;
auth_info = (struct t_auth_info *)in_val;
@ -434,16 +431,16 @@ auth_set_env(long in_val)
{
for (pam_env = pam_envlist; *pam_env != NULL; ++pam_env)
{
eq_pos = g_pos(*pam_env, "=");
char *str = *pam_env;
int eq_pos = g_pos(str, "=");
if (eq_pos >= 0 && eq_pos < 250)
if (eq_pos > 0)
{
g_strncpy(item, *pam_env, eq_pos);
g_strncpy(value, (*pam_env) + eq_pos + 1, 255);
g_setenv(item, value, 1);
str[eq_pos] = '\0';
g_setenv(str, str + eq_pos + 1, 1);
}
g_free(*pam_env);
g_free(str);
}
g_free(pam_envlist);