hero123457/uhd
1
0
Fork 0
mirror of https://github.com/EttusResearch/uhd.git synced 2026-10-25 17:36:10 +00:00
Code Issues Projects Releases Wiki Activity

python: Fix dropped-sample calculation in benchmark_rate.py

Browse Source 
This fixes a subtle bug, where a variable to cache the timestamp of an
error gets bound to the metadata instead of creating a copy thereof.
Without this fix, the calculation of dropped samples would always be 0,
because the difference in timestamps would incorrectly be always zero.
This fix will now make a copy of the timestamp.

Shoutout to GitHub user bhorsfield for finding this issue.
This commit is contained in:
Martin Braun 2021-09-22 16:17:08 +02:00 committed by Aaron Rossetto
parent 30a40395b9
commit b34e2f0593
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
host/examples/python/benchmark_rate.py
View File

@ -210,16 +210,18 @@ def benchmark_rx_rate(usrp, rx_streamer, random, timer_elapsed_event, rx_statist
# Reset the overflow flag
if had_an_overflow:
had_an_overflow = False
num_rx_dropped += uhd.types.TimeSpec(
metadata.time_spec.get_real_secs() - last_overflow.get_real_secs()
).to_ticks(rate)
num_rx_dropped += (metadata.time_spec - last_overflow).to_ticks(rate)
elif metadata.error_code == uhd.types.RXMetadataErrorCode.overflow:
had_an_overflow = True
last_overflow = metadata.time_spec
# Need to make sure that last_overflow is a new TimeSpec object, not
# a reference to metadata.time_spec, or it would not be useful
# further up.
last_overflow = uhd.types.TimeSpec(
metadata.time_spec.get_full_secs(),
metadata.time_spec.get_frac_secs())
# If we had a sequence error, record it
if metadata.out_of_sequence:
num_rx_seqerr += 1
logger.warning("Detected RX sequence error.")
# Otherwise just count the overrun
else:
num_rx_overruns += 1