Alternate text (alt text) improves the documentation experience for
screen readers and for other accessibility tools.
Task-number: QTBUG-135098
Pick-to: 6.11
Change-Id: Ia1793ff3e0bacd8cfdad2e8c04725a5093ed30aa
Reviewed-by: David Boddie <david.boddie@qt.io>
Added a \note, but keeping the example to show how to create custom
transports.
Pick-to: 6.10
Change-Id: Idf3b22532f6e0b94a0113cea6152a36e81398ea9
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Move the example IODevices to be used with websockets
under the mqtt umbrella.
Two (private) devices are created; QMqttSecureWebSocketIO
and QMqttWebSocketIO
Fixes: QTBUG-129171
Change-Id: Ib7d37150c3a229e882a0c04a32cdd8b7929baf3b
Reviewed-by: Jøger Hansegård <joger.hansegard@qt.io>
The example does not build with latest changes.
As it turns out there is a mismatch between the topic property
and the connected signal. Since the signal is not used, it is
removed in the hope that it will then build.
The error message from the build is:
Failure Summary:
The build failed due to a compilation error in 'qmlmqttclient.cpp'.
The function 'QmlMqttSubscription::topicChanged()' was called without
the required 'QString' argument.
Log snippet:
error: no matching function for call to ‘QmlMqttSubscription::topicChanged()’
note: candidate: ‘void QmlMqttSubscription::topicChanged(QString)’
note: candidate expects 1 argument, 0 provided
Change-Id: Ia8cedda578e2f2c082354892bd00cb9fd25b5652
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
According to QUIP-18 [1], all example files should be
LicenseRef-Qt-Commercial OR BSD-3-Clause
[1]: https://contribute.qt-project.org/quips/18
Pick-to: 6.7
Task-number: QTBUG-121787
Change-Id: I1133ca3b2daf487dbbc2ddae6b94d7f20239ed49
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
Remove the call m_client.state(), it seems to be unnecessary (just like
in the Quicksubscription example).
Pick-to: 6.6 6.5
Task-number: QTBUG-110893
Change-Id: I460f12f3d4b33388013cb8250149239a6b0f1c94
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
Provide the missing documentation for the Quickpublication example
Task-number: QTBUG-110893
Change-Id: I002208e2e036a09acd68621f075bed7a11b6598f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@qt.io>
The revamp includes:
- Update the screenshot
- Rename the example
- Add examplecategory : connectivity
- Update the description and snippets to reflect the current
state of the code
Task-number: QTBUG-110893
Change-Id: Id4edd325a539838fb5fa5c6b7fbbbfe4b0c683ce
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Remove m_client.state() call from QmlMqttClient::setPort, it seems to
be unnecessary.
Pick-to: 6.6 6.5
Task-number: QTBUG-110893
Change-Id: I4e1d8d2daf16da6c588f1b0b339ea863a22b32c0
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
Fix the qmllint warnings in the quickpublication example.
Pick-to: 6.6 6.5
Task-number: QTBUG-110893
Change-Id: If78a908807ee8a5f6f693d159a05a9ee91b1e38d
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Remove the version numbers according to revamp the guideline.
Pick-to: 6.6 6.5
Task-number: QTBUG-110893
Change-Id: I9e8fdd0fa54b3218efd2c55bd3dac3137d43e756
Reviewed-by: Juha Vuolle <juha.vuolle@qt.io>
Fix the qmllint warnings in the quicksubscription example.
Pick-to: 6.6 6.5
Task-number: QTBUG-110893
Change-Id: I4f633573b8c8f28eb65d7d4a57d4a63d8b7f5881
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Remove the version numbers according to the guideline
Task-number: QTBUG-110893
Change-Id: I5e1bf98a6180be039f385a8e4376dcd01df2e8c4
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
Reviewed-by: Juha Vuolle <juha.vuolle@qt.io>
Use the list initializer constructor of QStringList to make the code
more modern/compact.
Task-number: QTBUG-110893
Change-Id: Idf1cfb400e19cad87b70a40735fa17c87cf7fb30
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
As part of revamping the MQTT examples, replace QLatin1Strings with
_L1 literals.
Also replace QLatin1Chars and QStringLiterals with the appropriate
u'' and u""_s literals.
Task-number: QTBUG-110893
Change-Id: I784f5faa23e51666b6edf36eb9692c0f7c186f70
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
When using a websocket as the underlying IO device we must specify
that the device is sequential, to avoid spurious protocol violation
condition when packets are split across websocket frame boundaries.
The standard specifically states: "The receiver MUST NOT assume that
MQTT Control Packets are aligned on WebSocket frame boundaries."
New MQTT brokers like FlashMQ rely on well-behaved receivers.
Change-Id: Ia8e7fb0cf1cc518b364625b1955fb6b9ee44b7ef
Pick-to: 6.5
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@qt.io>
Remove "Example" from the name of the example.
Add examplecategory.
Add a short explanation and a few code snippets.
Task-number: QTBUG-110893
Change-Id: I0e4e29b9cd86c4950fdd0263ecec54e8927b2c3c
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Fix some warnings that were reported by the MSVC compiler with the Wall
setting:
- use static_cast for signed/unsigned conversion
- use QString::fromUtf8 instead of the QByteArray constructor
Pick-to: 6.5
Task-number: QTBUG-110893
Change-Id: Ic982d3c16feb1ebcef729b4dfd023cc3b5017fec
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Remove the word "Example" from the name of the example.
Add the example to the "Connectivity" Category.
Update the screenshot - the example no longer has a ping button.
Task-number: QTBUG-110893
Change-Id: Ieedb32800804fc336ba0e3bd0c8f3b9e4cd13527
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Fix some signed/unsigned conversion warnings in the Simple Client
example reported by Visual Studio with the Wall compiler settings.
Pick-to: 6.5
Task-number: QTBUG-110893
Change-Id: I0a1851098d314c63195eb2366a6f87f42a4bbed4
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@qt.io>
Fix some signed/unsigned conversion warnings.
Add explicit QMqttSubscription::Unsubscription case.
These warnings were reported by Visual Studio with the Wall compiler
setting.
Pick-to: 6.5
Task-number: QTBUG-110893
Change-Id: Ief64c4a04ba679f52c3e256aa96bb8f239ae68e9
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@qt.io>
According to the guideline "Example" should be not part of the name of
the example - remove it.
Add example to the Connectivity category.
Update the screenshot as the current one is obsolete. The application
no longer has a ping button but it has username and password fields.
Task-number: QTBUG-110893
Change-Id: Id9608ea6e76a3a7e89b0fd491d9fb329cfcbedc3
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
The example is not documented and it is also missing from the
examples-manifest.xml file. However, it can be still useful
for debugging or for performing small tests, so move it to
the tests/manual folder.
The qmake project files are kept for the examples because the
CI builds the examples with CMake and qmake. Now that this has
been moved to tests/manual, the .pro files can be removed.
Change-Id: Id69c3c6896d98b543ff5bd493592d06a27746496
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@qt.io>
This also fixes the example, which was erroring out when
the server picked a sub-protocol due to a bug in QWebSocket
Pick-to: 6.4
Task-number: QTBUG-108276
Change-Id: I582facd79bb5af7e068941d59e2d44b57a39aebc
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@qt.io>
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
QMqttClient is not meant to be directly exported to QML. One reason is
that it uses quint16 for port declaration to minimize size of the class.
However, that is not properly handled on all platforms for the QML
engine.
Instead create a proper wrapper for the client and only expose required
elements.
Fixes: QTBUG-80440
Pick-to: 6.4
Change-Id: Id4066ce24338b0270af05b06c6216c1755dab533
Reviewed-by: Karsten Heimrich <karsten.heimrich@qt.io>
CMakeLists.txt and .cmake files of significant size
(more than 2 lines according to our check in tst_license.pl)
now have the copyright and license header.
Existing copyright statements remain intact
Task-number: QTBUG-88621
Change-Id: I40135f08b4e89e8e034ec764ffed3273fc60646a
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@qt.io>
Replace the current license disclaimer in files by
a SPDX-License-Identifier.
License files are organized under LICENSES directory.
Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: Ie4309963c8e17d4e7dad602f61a660246d5e23cb
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
- Remove '# generated from xyz.pro' comment from pro2cmake
- Remove automatic use of CMAKE_AUTORCC
- Only opt into CMAKE_AUTOUIC if .ui files are involved
- Remove explicit setting of CMAKE_INCLUDE_CURRENT_DIR
- Combine multiple find_package(Qt6 ... calls)
- use REQUIRED COMPONENTS
- sort components alphabetically
- Fix wrong indentations
- Use (only) one empty line after multi-line commands
Pick-to: 6.3
Change-Id: Idf2f3d5a09a496fa5c578bbeae84f3560549f1a9
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
qt_examples_build_begin needs the EXTERNAL_BUILD flag
to know that it's safe to build examples as ExternalProjects.
It still won't do it in CI until we enable building
examples as ExternalProjects for prefix builds.
This is preparation for that.
Pick-to: 6.2 6.3
Task-number: QTBUG-90820
Change-Id: If3e2e42c6a1540cf1c7e80bc7c3f3dfc28ee40eb
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Setting the QT_NO_INTERNAL_COMPATIBILITY_FUNCTIONS variable
in the project ensures we ported away from old API calls.
Task-number: QTBUG-86815
Change-Id: I589f0192370a932ac10088656eaee1e35a41ea73
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
And use an updated coin instruction file.
Change-Id: I852d38febe9ecaa86c516b7f4a0451d0f80d8011
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@qt.io>
Apparently a new configuration in our CI.
Fixes: QTBUG-81064
Task-number: QTQAINFRA-2576
Change-Id: I022b56fd4fae487dfb84041c30ce061a28e5484c
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
In very few cases, the installation step for the console
example might copy the configuration.h header of both
subprojects concurrently. In that case Mac bails out with an
error.
Avoid this by iterating ordered.
Change-Id: Ic9dde91b1200a04ae598210f8b432d6efdd5d5c8
Fixes: QTBUG-80363
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Since dcf3bbb980 introduced
autoKeepAlive, users should not send a ping message manually
unless it is disabled.
Change-Id: I4b717e2aebc8f40cabf009d4df7e1d146988d434
Fixes: QTBUG-79444
Reviewed-by: hjk <hjk@qt.io>
Use the QMqttClient::connectToHostEncrypted() version taking a
QSslConfiguration instead of applying global settings.
Furthermore, the deprecated version will be removed in Qt6.
Change-Id: I4b2a9ff2616ed1c0c645d0081719f2d40c6e3b20
Reviewed-by: hjk <hjk@qt.io>
