1
0
mirror of https://github.com/qt/qtmqtt.git synced 2026-10-25 16:16:26 +00:00

Fix Qt-RangeLoopDetach Axivion warnings

- use std::as_const() where possible, and introduce an intermediate
  local const variable where it is not.

Axivion-Id: qt_Add-ons_qtmqtt_dev_linux:SV34
Axivion-Id: qt_Add-ons_qtmqtt_dev_linux:SV35
Axivion-Id: qt_Add-ons_qtmqtt_dev_linux:SV36
Axivion-Id: qt_Add-ons_qtmqtt_dev_linux:SV37
Task-number: QTBUG-144762
Change-Id: I7b6d53116269007aca7d6f050b2abeb2515e9390
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
(cherry picked from commit 14de26f60b)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Tatiana Borisova 2026-07-21 15:02:39 +02:00 committed by Qt Cherry-pick Bot
parent c2cbdfe281
commit 8f5fec801a

View File

@ -771,15 +771,15 @@ quint16 QMqttConnection::unusedPacketIdentifier() const
void QMqttConnection::cleanSubscriptions()
{
for (auto item : m_pendingSubscriptionAck)
for (auto item : std::as_const(m_pendingSubscriptionAck))
item->setState(QMqttSubscription::Unsubscribed);
m_pendingSubscriptionAck.clear();
for (auto item : m_pendingUnsubscriptions)
for (auto item : std::as_const(m_pendingUnsubscriptions))
item->setState(QMqttSubscription::Unsubscribed);
m_pendingUnsubscriptions.clear();
for (auto item : m_activeSubscriptions)
for (auto item : std::as_const(m_activeSubscriptions))
item->setState(QMqttSubscription::Unsubscribed);
m_activeSubscriptions.clear();
}
@ -1390,7 +1390,8 @@ QByteArray QMqttConnection::writePublishProperties(const QMqttPublishProperties
// 3.3.2.3.8 Subscription Identifier
if (properties.availableProperties() & QMqttPublishProperties::SubscriptionIdentifier) {
for (auto id : properties.subscriptionIdentifiers()) {
const auto subscriptionIds = properties.subscriptionIdentifiers();
for (auto id : subscriptionIds) {
qCDebug(lcMqttConnectionVerbose) << "Publish Properties: Subscription ID:" << id;
packet.append(char(0x0b));
packet.appendRawVariableInteger(id);