hero123457/qtmqtt
1
0
Fork 0
mirror of https://github.com/qt/qtmqtt.git synced 2026-10-25 16:16:26 +00:00
Code Issues Projects Releases Wiki Activity

Tst_QMqttSubscription: fix -Wunused-lambda-capture

Browse Source 
Says Clang:

  tst_qmqttsubscription.cpp:515:92: warning: lambda capture 'client' is not used [-Wunused-lambda-capture]
    515 |         connect(subscriptions[i], &QMqttSubscription::messageReceived, subscriptions[i], [&client, topic, &received](QMqttMessage msg) {
        |                                                                                           ~^~~~~~~
  tst_qmqttsubscription.cpp:545:92: warning: lambda capture 'client' is not used [-Wunused-lambda-capture]
    545 |         connect(subscriptions[i], &QMqttSubscription::messageReceived, subscriptions[i], [&client, topic, &received](QMqttMessage msg) {
        |                                                                                           ~^~~~~~~
  tst_qmqttsubscription.cpp:576:92: warning: lambda capture 'client' is not used [-Wunused-lambda-capture]
    576 |         connect(subscriptions[i], &QMqttSubscription::messageReceived, subscriptions[i], [&client, topic, &received](QMqttMessage msg) {
        |                                                                                           ~^~~~~~~

Fix by removing the problematic capture. I don't know why it doesn't
complain about `topic`, which also looks unused.

Amends c383083270 (picked to 6.8).

Pick-to: 6.10 6.8
Change-Id: I52850ae4ff9b5e2faee86cd8252d78ce5f0908ff
Reviewed-by: Even Oscar Andersen <even.oscar.andersen@qt.io>
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@qt.io>
(cherry picked from commit a3c58404a4)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Marc Mutz 2026-03-23 18:24:54 +01:00 committed by Qt Cherry-pick Bot
parent 8f031f14fb
commit 3368252b0d
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/auto/qmqttsubscription/tst_qmqttsubscription.cpp
View File

@ -512,7 +512,8 @@ void Tst_QMqttSubscription::qtbug_135653_connected()
for (int i = 0; i < 10; ++i) {
bool received = false;
subscriptions[i] = client.subscribe(topic);
connect(subscriptions[i], &QMqttSubscription::messageReceived, subscriptions[i], [&client, topic, &received](QMqttMessage msg) {
connect(subscriptions[i], &QMqttSubscription::messageReceived, subscriptions[i],
[topic, &received](QMqttMessage msg) {
received = (msg.payload() == "Hello World");
});
client.publish(topic, QString(QLatin1String("Hello World")).toLocal8Bit(), 1, true);
@ -542,7 +543,8 @@ void Tst_QMqttSubscription::qtbug_135653_not_connected()
client.connectToHost();
QTRY_VERIFY2(client.state() == QMqttClient::Connected, "Could not connect to broker.");
subscriptions[i] = client.subscribe(topic);
connect(subscriptions[i], &QMqttSubscription::messageReceived, subscriptions[i], [&client, topic, &received](QMqttMessage msg) {
connect(subscriptions[i], &QMqttSubscription::messageReceived,
subscriptions[i], [topic, &received](QMqttMessage msg) {
received = (msg.payload() == "Hello World");
});
client.publish(topic, QString(QLatin1String("Hello World")).toLocal8Bit(), 1, true);
@ -573,7 +575,8 @@ void Tst_QMqttSubscription::qtbug_135653_not_unsubscribed()
client.connectToHost();
QTRY_VERIFY2(client.state() == QMqttClient::Connected, "Could not connect to broker.");
subscriptions[i] = client.subscribe(topic);
connect(subscriptions[i], &QMqttSubscription::messageReceived, subscriptions[i], [&client, topic, &received](QMqttMessage msg) {
connect(subscriptions[i], &QMqttSubscription::messageReceived,
subscriptions[i], [topic, &received](QMqttMessage msg) {
received = (msg.payload() == "Hello World");
});
client.publish(topic, QString(QLatin1String("Hello World")).toLocal8Bit(), 1, true);